Archive
Michael MULLER
-
Avoid to update parameters inside routine’s bodies
Reassigning parameter of function to a new value within the body of the method/closure, is a confusing and questionable practice. Use a temporary variable…
-
Avoid to cover two dimensional ranges with nested for loop
Nested for loops are not a good practice because for loops are using an increment to cover a range, and nested for loops are…
-
Avoid Public finalize() methods
A program should never call finalize explicitly, except to call super.finalize() inside an implementation of finalize(). In mobile code situations, the otherwise error prone…
-
Avoid confusing initialization for variables declared on the same line
Destructuring assignment are a practical sugar syntax, but due to dynamic typing, ommitting the parentheses lead to a syntactically correct, but however functionnally incorrect,…
-
Avoid unexpected closure inside parentheses call
If a method is called and the last parameter is an inline closure then it can be declared outside of the method call parentheses,…
-
The code is managing too many files together
The number of files declared in the FILE-CONTROL should not be excessive.
-
The code contains too many unnecessary COMPUTE
COMPUTE verb should be restricted to usage in combination with the ROUNDED clause or a function call or for complex computing expression.
-
The code contains too many paragraph labels not followed by a dot
As much as possible, developers should always terminate paragraph labels with a dot.
-
The code contains too many not aligned END instructions
For code readability purpose, developers should always align end keywords with the corresponding instruction. The END-xxx keywords should be aligned on the same column…
-
The code contains too many long PIC declaration pattern
While describing a PICTURE, once the length of a sequence exceeds 3 characters, use the factorized notation. Edition pictures (presence of Z) are not…