Constructors with a return value can be unproductive in PHP

This code insight counts a violation each time the script has a constructor with a return value

” <?php
class foo {

function foo(){
$error = ”; // is set when something goes wrong
// things that can go wrong
return $error;
}
}

$foo = new foo();

?>”

Remedy –

“Review the source code and if the issue is related to the management of the errors you can always adopt the approach below:
If something goes wrong in the constructor you can either:
– Throw an exception (PHP5 only)
– Put this functionality in a separate function and call it. This function can then either return the object or an error.”

” <?php
class foo {

function foo(){
// things that can not go wrong
}

function createFoo(){
// is set to something else
// when something goes wrong
$error = new foo();

// things that can go wrong

return $error;
}
}

$foo = foo::createFoo();

?>”