Why you should care

A simple semicolon is used to end the items of structures, signatures and objects as these semicolons are considered mandatory. The double semicolon is also useful as it leaves no ambiguity in the code. It is required as it is used at the end of each clause as required by the bash syntax in order to parse the command correctly. It is only used in case constructs to indicate that the end of an alternative.

Business Impacts

It is recommended to add a double semi-colon as it prevents the code from having risks and lets the code be more productive.

Production Risk

CAST Recommendations

References

https://caml.inria.fr/pub/docs/tutorial-camlp4/tutorial005.html
https://stackoverflow.com/questions/16905183/dash-double-semicolon-syntax
http://www.linuxquestions.org/questions/linux-newbie-8/bash-scripting-options-double-semicolon-4175600617/

Style Guide

How we detect

This code insight shows that an inconsistency is found around esac keyword due to the absence of double semi-colon after the last case entry.
Explanation : the analyzer expect the esac instruction to be in the same level than its associated case. Each case entry introduces a new statement, while each double semicolon leave this “entry” statement. If the ;; is forgotten, the esac is not in the same imbrication level than the associated case, and that is the most ofen the cause of this alert…

About CAST and Highlight’s Code Insights

Over the last 25 years, CAST has leveraged unique knowledge on software quality measurement by analyzing thousands of applications and billions of lines of code. Based on this experience and community standards on programming best practices, Highlight implements hundreds of code insights across 15+ technologies to calculate health factors of a software.

See features How it works