Deep functions are a Production Risk in JavaScript
if, do, for, while, case,
The depth threshold (max valid depth) is tuned to 5.
Example :
function TooDeepFunction () {
while (toto) { // depth 1
print ‘plouf’;
for (;;) { // depth 2
if (BOOL == 1) { // depth 3
print ‘CAST’;
}
else if (name = ‘JOHN DOE’) { // else :depth 3, if: depth 4
echo ‘CAST’;
switch (INDEX) { // depth 5
case 1 :
if (BOOL >= 1) { // depth 6 ==> VIOLATION!
print ‘example’;
}
default :
return;
}
}
}
}
}
Why you should care
Business Impacts
Combining multiple lines of code on one line is risky because it makes the code unreadable and less productive in the long run.
CAST recommendations
References
https://softwareengineering.stackexchange.com/questions/104066/single-line-statements-good-practices
About CAST and Highlight’s Code Insights
Over the last 25 years, CAST has leveraged unique knowledge on software quality measurement by analyzing thousands of applications and billions of lines of code. Based on this experience and community standards on programming best practices, Highlight implements hundreds of code insights across 15+ technologies to calculate health factors of a software.