Why you should care
SWITCH statements are useful when there are many different cases depending on the value of the same expression. However, code will me more readable with IF statements for one or two cases.
How we detect
CAST Highlight counts one occurrence each time a SWITCH structure has less than 3 cases statements.
Bad Code
switch (variable) {
case 0:
doSomething();
break;
default:
doSomethingElse();
break;
}
Good Code
switch (variable) {
case 0:
doSomething();
break;
case 1 :
doSomething();
break;
default:
doSomethingElse();
break;
}
References
MISRA C:2012, 16.6
https://rules.sonarsource.com/c/RSPEC-1301
https://rules.sonarsource.com/c/RSPEC-1301
About CAST and Highlight’s Code Insights
Over the last 25 years, CAST has leveraged unique knowledge on software quality measurement by analyzing thousands of applications and billions of lines of code. Based on this experience and community standards on programming best practices, Highlight implements hundreds of code insights across 15+ technologies to calculate health factors of a software.