File Records with no COPY Clause can be risky

Software ResiliencyProgramming Best Practices

File Records with no COPY Clause can be risky

This code insight count a violation each time a file record has more than one data and is not in a copy clause.

Bad:

000130 DATA DIVISION.
000140 FILE SECTION.
000150 FD SALES-FILE
000160       RECORDING MODE IS F.
000170
000180 01 SALES-RECORD.
000190       05 BROKER-REGION PIC 9.
000200       05 BROKER-CITY PIC X(19).
000210       05 BROKER-NAME PIC X(20).
000220
000230 WORKING-STORAGE SECTION.

 Good :

000130 DATA DIVISION.
000140 FILE SECTION.
000150 FD STUDENT-FILE
000160 RECORD CONTAINS 43 CHARACTERS
000170 DATA RECORD IS STUDENT-IN.
000180 01 STUDENT-IN PIC X(43).
000190
000200 FD PRINT-FILE
000210       RECORD CONTAINS 80 CHARACTERS
000220       DATA RECORD IS PRINT-LINE.
000230  COPY CopyPrintFileRecord
000240
000250 WORKING-STORAGE SECTION.

 

 

5362

Why you should care

File records should be described in a copy clause.

Business Impacts

Production Risk

CAST recommendations

References

5362

About CAST and Highlight’s Code Insights

Over the last 25 years, CAST has leveraged unique knowledge on software quality measurement by analyzing thousands of applications and billions of lines of code. Based on this experience and community standards on programming best practices, Highlight implements hundreds of code insights across 15+ technologies to calculate health factors of a software.

See featuresHow it works