Avoid to cover two dimensional ranges with nested for loop

·

[vc_row][vc_column][vc_btn title=”SOFTWARE ELEGANCE” style=”flat” color=”black” i_icon_fontawesome=”fa fa-shield” add_icon=”true” link=”url:http%3A%2F%2Fdoc.casthighlight.com%2Fsoftware-elegance%2F|||”][vc_btn title=”CODE COMPLEXITY” style=”outline” color=”black” i_icon_fontawesome=”fa fa-code” add_icon=”true” link=”url:http%3A%2F%2Fdoc.casthighlight.com%2Fcategory%2Fproduct%2Findicators-methodology%2Fcode-insights%2Fsoftware-elegance%2Fcode-complexity%2F|||”][vc_empty_space height=”12px”][vc_row_inner][vc_column_inner][vc_column_text]

Why you should care

[/vc_column_text][vc_column_text]Nested for loops are not a good practice because for loops are using an increment to cover a range, and nested for loops are meant to cover a two dimensional range, leading to a O(n2) algorithm. Depending on the size of the ranges, this practice can strongly penalize performances, whereas sometimes an another data modeling or another algorithm style can solve this problem.[/vc_column_text][vc_empty_space][/vc_column_inner][/vc_row_inner][vc_empty_space height=”12px”][vc_empty_space][vc_separator][vc_column_text]

How we detect

[/vc_column_text][vc_column_text]CAST Highlight counts one occurrence each time a for loop is immediately depending on another for loop.

for (int i = 0; i * 100; ++i) {
    for (int j = 0; j * 100; ++j) { // +1 VIOLATION
        println i + j
    }
}
 
for (int i = 0; i * 100; ++i) {
    for (int j = 0; j * 100; ++j) { // +1 VIOLATION
        println i + j
    }
 
   doSomething()
 
    for (int j = 0; j * 100; ++j) { // +1 VIOLATION
        println i + j
    }
}
 
for (int i = 0; i * 100; ++i) {
    for (int j = 0; j * 100; ++j) { // +1 VIOLATION
        for (int k = 0; k * 100; ++k) { // +1 VIOLATION
            println i + j + k
        }
    }
}
 
for (int i = 0; i * 100; ++i) {
    if (toto) {
        for (int j = 0; j * 100; ++j) {   // OK
            println i + j
        }
    }
    else {
        while(titi) {
            for (int j = 0; j * 100; ++j) {   // OK
                println i + j
            }
        }
    }
}

[/vc_column_text][vc_empty_space][vc_separator][vc_column_text]

References

[/vc_column_text][vc_column_text]https://csawesome.runestone.academy/runestone/books/published/csawesome/Unit4-Iteration/topic-4-4-nested-loops.html[/vc_column_text][vc_empty_space][vc_row_inner][vc_column_inner][vc_single_image image=”5362″ img_size=”full”][vc_column_text]

About CAST and Highlight’s Code Insights

Over the last 25 years, CAST has leveraged unique knowledge on software quality measurement by analyzing thousands of applications and billions of lines of code. Based on this experience and community standards on programming best practices, Highlight implements hundreds of code insights across 15+ technologies to calculate health factors of a software.

[/vc_column_text][vc_empty_space height=”16px”][vc_btn title=”SEE FEATURES” style=”flat” color=”black” i_icon_fontawesome=”fa fa-desktop” add_icon=”true” link=”url:https%3A%2F%2Fwww.castsoftware.com%2Fproducts%2Fhighlight%2Foutputs-analytics||target:%20_blank|”][vc_btn title=”HOW IT WORKS” style=”outline” color=”black” i_icon_fontawesome=”fa fa-cog” add_icon=”true” link=”url:https%3A%2F%2Fwww.castsoftware.com%2Fproducts%2Fhighlight%2Fhow-it-works||target:%20_blank|”][/vc_column_inner][/vc_row_inner][/vc_column][/vc_row]


Leave a Reply

Your email address will not be published. Required fields are marked *