Multiline Conditional Expressions should be avoided

This code insight counts one violation each time a multiline conditional expression is encountered.

bad

x = 1 if cond
else 2

good

x = 1 if cond else 2

Why you should care

Conditional expressions are mechanisms that provide a shorter syntax for if statements. For example: x = 1 if cond else 2.

May be harder to read than an if statement. The condition may be difficult to locate if the expression is long.

Okay to use for one-liners. In other cases prefer to use a complete if statement.

Business Impacts

It is recommended to avoid these in order to ensure the code is more readable and cost effective.

Cost

CAST recommendations

References

http://support.objectivity.com/sites/default/files/docs/objy/R11_0_0/html/java/guide/jgdObjectQualification.html

About CAST and Highlight’s Code Insights

Over the last 25 years, CAST has leveraged unique knowledge on software quality measurement by analyzing thousands of applications and billions of lines of code. Based on this experience and community standards on programming best practices, Highlight implements hundreds of code insights across 15+ technologies to calculate health factors of a software.

See features How it works