Magic Numbers are a Production Risk
interger : (0|0[xX])?[0123456789ABCDEF]+([lL]?
decimal : ([0-9]*\.[0-9]+|[0-9]+\.)
- real : [0-9]+[eE][+-]?[0-9]+
- one digit integer
- 0.0, .0, 0.
Note : a constant is a variable assigned only one time in its scope.
PI = 3.14 # not a violation because assigned to a constant CONST = 123 * 456 # 2 violations : the assignation is an expression (containing 2 Magics) a = 12 # violation because assigned to a variable if (b): a = b
Why you should care
Avoid litteral numeric constants.
About CAST and Highlight’s Code Insights
Over the last 25 years, CAST has leveraged unique knowledge on software quality measurement by analyzing thousands of applications and billions of lines of code. Based on this experience and community standards on programming best practices, Highlight implements hundreds of code insights across 15+ technologies to calculate health factors of a software.